search

canonical / testflinger

https://testflinger.readthedocs.io/en/latest/
GNU General Public License v3.0
11 stars 17 forks source link

fix(device-connectors): Remove unused code #339

Closed thp-canonical closed 1 month ago

thp-canonical commented 1 month ago

Description

The check whether RealSerialLogger or StubSerialLogger is used is done in the def SerialLogger() function now:

https://github.com/canonical/testflinger/blob/88454c9d61a0f66e0dff50f2b1f9ae8c4247d57c/device-connectors/src/testflinger_device_connectors/devices/__init__.py#L69-L71

In addition, grep'ing for \.stub (and even just stub) seems to not yield any results, so the self.stub property might not be used at all (and even if it would be, it would always be overwritten by the unconditional self.stub = False in the line after the if block.

Resolved issues

None, but makes the code easier to follow.

Documentation

No changes.

Web service API changes

No changes.

Tests

I have not tested this.