search

canonical / testflinger

https://testflinger.readthedocs.io/en/latest/
GNU General Public License v3.0
11 stars 17 forks source link

Add agent_name in TF environment #354

Closed rmartin013 closed 3 weeks ago

rmartin013 commented 4 weeks ago

Description

It is currently impossible to guess the name of the device agent from a testflinger job running from a device agent queue. This is unfortunate since we have a few Riverside tools that abstract the complexity of a setup, given the device name as an argument. Adding it as an environment variable would reduce the development effort on those tools and can probably benefit as well to other use cases.

We feel the need for this change in the context of https://warthogs.atlassian.net/browse/PERI-572.

Resolved issues

Documentation

Web service API changes

Tests

rmartin013 commented 4 weeks ago

@plars I would like your review on this PR. I tried to test it using "snappy-device-agent muxpi provision -c default-agx-c30841.yaml test.json", but I am constantly running into timeout issue, and I feel there is probably a better way to test it. Since in that case, I don't need to provision a device to test it, but simply run a "env" command in the test phase.

We already discussed about this need, and I was feeling like it would probably be easier for you if I propose a patch

rmartin013 commented 3 weeks ago

@plars thanks for your review, I fixed that and a syntax error for getting the configuration. I finally managed to find the test command allowing me to check my change, so I am now pretty confident with it: snappy-device-agent muxpi runtest -c default-nano.yaml test.json

plars commented 3 weeks ago

/canonical/self-hosted-runners/run-workflows 3ae5b1ff8c1669dca25bb5be9a495637b75de9c2