sombrafam
commented
2 months ago @dosaboy hey, I added the logic to clean up any process when user stops it (Ctrl-C). Regarding the status progress, its already printing the status of the process:
Started: 0,1,2,5,6,7,8,10,11,14,15, Completed: 8,10,5,2, Unfinished: 0,1,6,7,11,14,15
Collecting hotsos reports for vault, machine: 16
Finished collection for nova-cloud-controller, machine: 7. 7 targets unfinished.
Started: 0,1,2,5,6,7,8,10,11,14,15,16, Completed: 8,10,5,2,7, Unfinished: 0,1,6,11,14,15,16
I had a go a testing this today but unfortunately the environment i ran it in cant access pypi (or at least the pipx install was hanging) and so it never got past that stage. One bit of feedback I think is worth providing from that is that when i killed hotsos-collector it left all those processes still running i.e. the ssh connections remained open and the remote processes were not killed (they were still trying to install hotsos). So at this stage I think (a) some status as to the progress of the install/run would be good so that if it is stuck that is a bit more obvious and (b) when you kill it like Ctrl-C it tries to actually stop+cleanup the commands it has issued.