search

canonical / ubuntu-advantage-desktop-daemon

GNU General Public License v3.0
3 stars 5 forks source link

Specify the gettext data_dirs for the polkit files to be translated #6

Closed seb128 closed 2 years ago

seb128 commented 2 years ago

The template update currently fails to include the polkit strings on the builders

xgettext: warning: file 'src/com.canonical.UbuntuAdvantage.policy.in' extension 'policy' is unknown; will try C

That's because it needs the files in /usr/share/gettext/its which are provided by policykit-1

robert-ancell commented 2 years ago

This its file is in po/its - is there a reason why that doesn't use that? I had to do it this way so it will build on all Ubuntu versions.

seb128 commented 2 years ago

hum, probably something needs to tell gettext to check in that directory? I will poke at it tomorrow

seb128 commented 2 years ago

Alright, I force pushed a reworked fix, similar to what was done in https://github.com/systemd/systemd/commit/b0faead2

seb128 commented 2 years ago

Which is explained in the meson i18n.gettext documentation

data_dirs: (Added 0.36.0) list of directories to be set for GETTEXTDATADIRS env var (Requires gettext 0.19.8+), used for local its files

robert-ancell commented 2 years ago

Thanks!