canonical / ubuntu-advantage-desktop-daemon

GNU General Public License v3.0
3 stars 5 forks source link

Use a system unit to improve security #8

Closed seb128 closed 2 years ago

seb128 commented 2 years ago

I'm proposing that one to help moving things forward but it's untested, the systemd job seems to work as it's installed and systemctl status report it as started once it's dbus activated but I'm unsure how to drive the service. Robert, could you check if activating a subscription is still working with the security feature activated? If so we should probably be able to merge the change as it is now, we can always tweak later if we want more confinement.

seb128 commented 2 years ago

Alright, I pushed some extra changes, the meson tweaks requested and I granted some extra permissions since the service needs to be able to contact the server and to write in /var. I confirmed that now status, attach and detach are working, it should be ready to merge from my perspective.

robert-ancell commented 2 years ago

We're missing the build-dependency in debian/control but I'll add that as a separate commit.