Add channel field to NoticePackage schema

petesfrench commented 1 year ago

Done

QA

Check out this feature branch
Run the site using the command ./run serve
View the site locally in your web browser at: http://0.0.0.0:8030/
Run through the following QA steps
[List additional steps to QA the new features or prove the bug has been reso lved]

Issue / Card

Fixes https://github.com/canonical/ubuntu-com-security-api/issues/123

codecov[bot] commented 1 year ago

Codecov Report

Merging #124 (fab179d) into main (7547f4f) will increase coverage by 0.01%. The diff coverage is 100.00%.

:exclamation: Current head fab179d differs from pull request most recent head 66f6eca. Consider uploading reports for the commit 66f6eca to get more accurate results

@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   80.92%   80.94%   +0.01%     
==========================================
  Files          25       25              
  Lines        1248     1249       +1     
==========================================
+ Hits         1010     1011       +1     
  Misses        238      238

Flag	Coverage Δ
python	`80.94% <100.00%> (+0.01%)`	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
tests/fixtures/payloads.py	`100.00% <ø> (ø)`
webapp/schemas.py	`92.48% <100.00%> (+0.03%)`	:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

petesfrench commented 1 year ago

@mtruj013 The other fields with the parameter allow_none=True (source_link and version_link) are omitted from the notice and ssn_notice test payload, do we need to add this one?

canonical / ubuntu-com-security-api