canonical / ubuntu-com-security-api

The API for CVEs and USNs data.
16 stars 9 forks source link

Decouple statuses and versions and add tests #137

Closed mtruj013 closed 6 months ago

mtruj013 commented 6 months ago

Done

Rationale

The current functionality requires you to provide a status query for every version. For the overhaul we want to be able to query for these independent of one another such that you can query for multiple versions and one status, for example.

QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-8817

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 92.95775% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 84.85%. Comparing base (cb65691) to head (33efc18). Report is 1 commits behind head on main.

:exclamation: Current head 33efc18 differs from pull request most recent head 689e287. Consider uploading reports for the commit 689e287 to get more accurate results

Files Patch % Lines
tests/test_routes.py 91.66% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #137 +/- ## ========================================== + Coverage 83.45% 84.85% +1.40% ========================================== Files 29 29 Lines 1408 1459 +51 ========================================== + Hits 1175 1238 +63 + Misses 233 221 -12 ``` | [Flag](https://app.codecov.io/gh/canonical/ubuntu-com-security-api/pull/137/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [python](https://app.codecov.io/gh/canonical/ubuntu-com-security-api/pull/137/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `84.85% <92.95%> (+1.40%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.