search

canonical / ubuntu-com-security-api

The API for CVEs and USNs data.
16 stars 9 forks source link

Retain functionality for empty status strings #141

Closed mtruj013 closed 3 months ago

mtruj013 commented 3 months ago

Done

Rationale

Before https://github.com/canonical/ubuntu-com-security-api/pull/137, version and status filtering had to be done together. For eg, to query for CVEs for jammy you'd need to write the query like so version="jammy"&status="". Now that these have been decoupled the same functionality is achieved with just version="jammy". This has already been refactored on the CVE overhaul branch, but the current CVE table form on u.com still uses the original querying functionality so this PR ensures there will be no errors while we finish the overhaul story.

QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-11570

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.00%. Comparing base (a136ecd) to head (55311e3). Report is 1 commits behind head on main.

:exclamation: Current head 55311e3 differs from pull request most recent head b5e1961

Please upload reports for the commit b5e1961 to get more accurate results.

Files Patch % Lines
webapp/views.py 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #141 +/- ## ========================================== - Coverage 85.04% 85.00% -0.05% ========================================== Files 29 29 Lines 1478 1480 +2 ========================================== + Hits 1257 1258 +1 - Misses 221 222 +1 ``` | [Flag](https://app.codecov.io/gh/canonical/ubuntu-com-security-api/pull/141/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [python](https://app.codecov.io/gh/canonical/ubuntu-com-security-api/pull/141/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `85.00% <66.66%> (-0.05%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.