canonical / ubuntu-desktop-installer

Ubuntu Desktop Installer
GNU General Public License v3.0
538 stars 94 forks source link

mantic: broken automatic partition setup #2252

Closed jbicha closed 1 year ago

jbicha commented 1 year ago

Test Case

I am using Ubuntu 23.10 as my host. In GNOME Boxes, I created a 23.10 guest using today's ISO.

I clicked all the default options until I get to this confirmation screen with missing details in the devices and partitions sections.

Screenshot from 2023-07-18 13-52-36

Afterwards, I clicked Install and finished the rest of the dialog but it looked like the installer couldn't actually install anything so I was just left at the slideshow stage. No other errors or glitches were shown.

jpnurmi commented 1 year ago

Hey @jbicha, do you still have access to the system? Any chance to get the logs from /var/log/installer?

jpnurmi commented 1 year ago

Never mind, I'm just too used to bumping up the VM specs! :man_facepalming: I was able to reproduce the issue with the default 25.0 GiB storage.

jpnurmi commented 1 year ago

We need to add handling for the TOO_SMALL reason introduced in canonical/subiquity#1694.

2023-07-18 18:48:14.733330 DEBUG subiquity_client: GET http://localhost/storage/v2/guided?wait=true
2023-07-18 18:48:14.734688 DEBUG subiquity_client: ==> getGuidedStorageV2(true) {"status": "DONE", "error_report": null, "configured": null, "targets": [{"disk_id": "disk-vda", "allowed": [], "disallowed": [{"capability": "DIRECT", "reason": "TOO_SMALL", "message": null}, {"capability": "LVM", "reason": "TOO_SMALL", "message": null}, {"capability": "LVM_LUKS", "reason": "TOO_SMALL", "message": null}], "$type": "GuidedStorageTargetReformat"}, {"allowed": ["MANUAL"], "disallowed": [], "$type": "GuidedStorageTargetManual"}]}
jpnurmi commented 1 year ago

With the default 25 GiB disk gnome-boxes offers for Ubuntu 23.10, Subiquity refuses guided reformat (TOO_SMALL) even though manual installation with the simplest possible partition layout installs fine.

jbicha commented 1 year ago

Actually, I tried with 20GB which I believe was enough for Ubuntu 23.04.

jpnurmi commented 1 year ago

Fixed by:

The fix didn't make it on today's live but I tested with a 20GB disk and snap refresh ubuntu-desktop-installer and it installed fine. :+1:

latest/stable:    0+git.7fe84a1e 2023-07-20 (1165) 135MB classic