fix: Scrollbar should be in the side of the logview

canonical / ubuntu-flutter-plugins

A collection of Flutter plugins and packages for Ubuntu applications.

46 stars 11 forks source link

fix: Scrollbar should be in the side of the logview #397

Closed spydon closed 4 months ago

spydon commented 4 months ago

Previously the scrollbar was within the padding, which looked really strange. This also makes the scrollbar always visible when there is scrollable content.

d-loose commented 4 months ago

Ugh, I don't feel like debugging this now - it's probably related to https://github.com/fluttercommunity/get_it/pull/356. This shouldn't cause any issues elsewhere, since I'm not aware of a situation where we've registered multiple services of the same type, but we should definitely look into it and either pin get_it or fix the underlying problem

spydon commented 4 months ago

LGTM 👍

CI failure is due to get_it 7.6.8 - let's fix that separately

It had a legit failure on another test too, but the pipeline had fail fast on the tests (turned off now). I pinned get_it for now.