search

canonical / ubuntu-frame-vnc

Remote access to Ubuntu Frame, based on wayvnc
GNU General Public License v3.0
0 stars 0 forks source link

snap: add missing install hook #12

Closed Saviq closed 11 months ago

Saviq commented 11 months ago

Fixes #11

Saviq commented 11 months ago

This is more elaborate than the install hook in iot-gui-snaps or ubuntu-frame-vnc, is that necessary?

I started from Frame itself:

https://github.com/MirServer/ubuntu-frame/blob/main/snap/hooks/install

I suppose it's nicer to not ever start the service than to start and just stop it again, when on Classic?

AlanGriffiths commented 11 months ago

I suppose it's nicer to not ever start the service than to start and just stop it again, when on Classic?

The configure hook should run it before it starts anyway

Saviq commented 11 months ago

The configure hook should run it before it starts anyway

It's not clear to me that's the case…

https://snapcraft.io/docs/supported-snap-hooks#heading--the-configure-hook

Other hooks (e.g. install default-configure) explicitly say they run before the services start, but not configure.