search

canonical / ubuntu-frame

The foundation for many embedded graphical display implementations
GNU General Public License v3.0
159 stars 21 forks source link

[Merged by Bors] - Convert all `--diagnostic-path` paths to absolute #104

Closed graysonguarino closed 2 years ago

graysonguarino commented 2 years ago

Fixes #93 by using boost::filesystem::absolute() to convert all inputted paths to absolute paths. Also deals with the error case where a user attempts to input a file as the parent directory.

graysonguarino commented 2 years ago 
cmake-build-debug/frame --diagnostic-path nonexisting/tmp

Expect: an error Actual: no error

🤦 I forgot to check that case when migrating from boost::filesystem::canonical() to boost::filesystem::absolute().

AlanGriffiths commented 2 years ago

I forgot to check that case

That is the problem with manual testing

bors[bot] commented 2 years ago

Pull request successfully merged into main.

Build succeeded: