canonical / ubuntu-frame

The foundation for many embedded graphical display implementations
GNU General Public License v3.0
159 stars 21 forks source link

Not respecting snap-name #172

Closed kylecarhart closed 8 months ago

kylecarhart commented 8 months ago

Following this tutorial: https://discourse.ubuntu.com/t/how-to-configure-ubuntu-frame-for-multiple-outputs/33012

I am trying to set snap-name in my display config but it does not appear to take any effect. For example, I would like mir-kiosk-neverputt on my second monitor.

# ...
      HDMI-A-4:
        state: enabled  # {enabled, disabled}, defaults to enabled
        mode: 2560x1440@60.0    # Defaults to preferred mode
        position: [2560, 0]     # Defaults to [0, 0]
        orientation: normal   # {normal, left, right, inverted}, defaults to normal
        scale: 1
        group: 0        # Outputs with the same non-zero value are treated as a single display
        snap-name: mir-kiosk-neverputt

Working on my config in a separate file, then I cat it out to snap set: sudo snap set ubuntu-frame display=...

However when checking snap logs ubuntu-frame -n 50, I can see that my config has been stripped of the snap-name I provided...

2024-03-11T15:47:37-04:00 ubuntu-frame.daemon[1182]:       HDMI-A-4:
2024-03-11T15:47:37-04:00 ubuntu-frame.daemon[1182]:         state: enabled # {enabled, disabled}, defaults to enabled
2024-03-11T15:47:37-04:00 ubuntu-frame.daemon[1182]:         mode: 2560x1440@60.0   # Defaults to preferred mode
2024-03-11T15:47:37-04:00 ubuntu-frame.daemon[1182]:         position: [2560, 0]    # Defaults to [0, 0]
2024-03-11T15:47:37-04:00 ubuntu-frame.daemon[1182]:         orientation: normal    # {normal, left, right, inverted}, defaults to normal
2024-03-11T15:47:37-04:00 ubuntu-frame.daemon[1182]:         scale: 1
2024-03-11T15:47:37-04:00 ubuntu-frame.daemon[1182]:         group: 0   # Outputs with the same non-zero value are treated as a single display

Anything that I could be doing wrong here?

kylecarhart commented 8 months ago

Update... uninstalling ubuntu-frame and reinstalling with channel 20 seems to fix this.

Saviq commented 8 months ago

Thanks @kylecarhart, I can confirm this isn't working as intended, we'll get a fix in asap.

Saviq commented 8 months ago

In fact, I can't seem to get it to work on 20, either, both give me:

< -warning- > miral: Attempt to read custom output attribute (surface-title) that wasn't added
< -warning- > miral: Attempt to read custom output attribute (snap-name) that wasn't added    

Though that's only on startup, so may be before we've asked for them?

AlanGriffiths commented 8 months ago

I can confirm this works on the 20 track and not on the 22 track.

AlanGriffiths commented 8 months ago

The fix is available on edge. We will shortly be releasing Mir 2.16.4 with the fix, that version will be then be available on beta and, following internal testing, on candidate and then, after a "call for testing" on stable.