Closed AlanGriffiths closed 3 months ago
The code looks good and makes sense 👍 I am unsure how to test
check_for_exposed_outputs
properly though. I can trust that it works, but if you have a simple repo that I could try that would be good too
As previously discussed, we need better test rigging in this area. And, I think, the logic for overlapping, non-identical, outputs is suspect.
I trust it is clear that this rework doesn't break anything that worked before. (I could drop 59868aa, the "extract method" refactor should be uncontentious.
Fix true positives