search

canonical / ubuntu-frame

The foundation for many embedded graphical display implementations
GNU General Public License v3.0
159 stars 21 forks source link

Tidy up after static analysis #185

Closed AlanGriffiths closed 6 months ago

AlanGriffiths commented 6 months ago

Fix true positives

AlanGriffiths commented 6 months ago

The code looks good and makes sense 👍 I am unsure how to test check_for_exposed_outputs properly though. I can trust that it works, but if you have a simple repo that I could try that would be good too

As previously discussed, we need better test rigging in this area. And, I think, the logic for overlapping, non-identical, outputs is suspect.

I trust it is clear that this rework doesn't break anything that worked before. (I could drop 59868aa, the "extract method" refactor should be uncontentious.