Adjusting code to account for the fact that the returned app_id no longer ends with the .desktop suffix

canonical / ubuntu-frame

The foundation for many embedded graphical display implementations

GNU General Public License v3.0

159 stars 21 forks source link

Adjusting code to account for the fact that the returned app_id no longer ends with the .desktop suffix #205

Open mattkae opened 1 month ago

mattkae commented 1 month ago

relies on https://github.com/canonical/mir/pull/3629

What's new?

We dont' want a .desktop file suffix in the applicaiton id

AlanGriffiths commented 1 month ago

relies on canonical/mir#3629

We probably want to land code that works both with and without canonical/mir#3629 - otherwise we'd be be blocked from updating Frame without first releasing Mir

Saviq commented 1 month ago

@mattkae ping!

We just need to strip .desktop from the app id here, no?

mattkae commented 1 month ago

@mattkae ping!

We just need to strip .desktop from the app id here, no?

Yup! That's what I did in this PR

AlanGriffiths commented 2 weeks ago

Maybe I misunderstand, doesn't this still require the ".desktop" extension?

mattkae commented 2 weeks ago

Maybe I misunderstand, doesn't this still require the ".desktop" extension?

On the frontend, we read all of the X.desktop files. The app id is X in this case, unless otherwise specified inside of the desktop file. We then resolve X instead of X.desktop