Update messages for livepatch

canonical / ubuntu-pro-client

Ubuntu Pro Client for offerings from Canonical

https://canonical-ubuntu-pro-client.readthedocs-hosted.com/en/latest/

GNU General Public License v3.0

52 stars 69 forks source link

Update messages for livepatch #3076

Closed dheyay closed 1 month ago

dheyay commented 2 months ago

Fixes: #3063

Why is this needed?

This PR solves all of our problems because...

Test Steps

Checklist

[ ] I have updated or added any unit tests accordingly
[x] I have updated or added any integration tests accordingly
[ ] Changes here need to be documented, and this was done in:

Does this PR require extra reviews?

[ ] Yes
[x] No

github-actions[bot] commented 2 months ago

Jira: This PR is not related to a Jira item. (The PR title does not include a SC-#### reference)

GitHub Issues:

Fixes: #3063

Launchpad Bugs: No Launchpad bugs are fixed by this PR. (No commits have LP: #### references)

Documentation: The changes in this PR do not require documentation changes.

👍 this comment to confirm that this is correct.

github-actions[bot] commented 2 months ago

🌎 This PR changes translatable messages. 🌏

Please select which scenarios apply. For further explanation, please read our policy on message changes.

[ ] New messages are being added.
- We will ask translators to take a look and add translations if they have time, but it will not block this PR.
[x] Existing messages are being changed.
- ⚠️ Please add a comment with justification of why messages are being altered.
- If the changes are trivial (e.g. a typo fix), then translations must be preserved.
- If the changes are substantial, then we will ask translators to take a look and update translations if they have time, but it will not block this PR.
[ ] Existing messages are being deleted.
- No special action needed.

dheyay commented 2 months ago

🌎 This PR changes translatable messages. 🌏

Please select which scenarios apply. For further explanation, please read our policy on message changes.

* [ ]  New messages are being added.

  * We will ask translators to take a look and add translations if they have time, but it will not block this PR.

* [x]  Existing messages are being changed.

  * ⚠️ Please add a comment with justification of why messages are being altered.
  * If the changes are trivial (e.g. a typo fix), then translations must be preserved.
  * If the changes are substantial, then we will ask translators to take a look and update translations if they have time, but it will not block this PR.

* [ ]  Existing messages are being deleted.

  * No special action needed.

Existing messages are updated to use the word "coverage" instead of "support" which currently implies a relation to other means of support e.g "phone support", etc.

dheyay commented 2 months ago

Updated @orndorffgrant

orndorffgrant commented 2 months ago

Looks like the translations files need to be updated. Also, please keep the po file updates in a separate commit. Something like this should do it.

git reset HEAD~1
git add features uaclient/messages
git commit
./tools/update-pos.sh
git add debian/po
git commit -m "update-pos"