Open renanrodrigo opened 2 weeks ago
@lucasmoura @orndorffgrant @dheyay I want to do this to ALL commands but please take preliminary looks to make sure you agree with the structure - easier to change earlier when less commands are implemented/affected
@orndorffgrant I want to do this to all commands, yes - maybe incrementally, simple ones in this PR, if I find something more tricky (and I will) I can send it separate for ease of review. As it is a refactor anyway, we can merge without usability changes
@orndorffgrant I want to do this to all commands, yes - maybe incrementally, simple ones in this PR, if I find something more tricky (and I will) I can send it separate for ease of review. As it is a refactor anyway, we can merge without usability changes
@renanrodrigo makes sense. Maybe can you prioritize the subcommands that have their own module? The we'd only have "new" commands in this form and "old" commands in cli/__init__.py
(and no "in-between" commands in the better-but-not-as-good separate module form)
@renanrodrigo makes sense. Maybe can you prioritize the subcommands that have their own module? The we'd only have "new" commands in this form and "old" commands in
cli/__init__.py
(and no "in-between" commands in the better-but-not-as-good separate module form)
Not sure - some of those have been separated exactly because they are more complicated somehow. I'll try and see what happens
Why is this needed?
This PR solves all of our problems because this will set a new standard for the Pro Client CLI, which will be leveraged for the new UX implementation.
Test Steps
~This PR should contain only refactors.~ Yep check tox and behave, small changes to help text