search

canonical / ubuntu-pro-client

Ubuntu Pro Client for offerings from Canonical
https://canonical-ubuntu-pro-client.readthedocs-hosted.com/en/latest/
GNU General Public License v3.0
51 stars 69 forks source link

Add vulnerabilities API #3177

Open lucasmoura opened 2 weeks ago

lucasmoura commented 2 weeks ago

Why is this needed?

We are adding support for the u.pro.security.vulnerabilities.cve.v1 endpoint. This endpoint will list all the fixable CVEs in the system.

This is a draft PR just for us to align on the parsing strategy here. I still need to write all of the tests for this feature (unit and integration)

Test Steps

  1. Launch a xenial container
  2. Run pro api u.pro.security.vulnerabilities.cve.v1
  3. See that we have valid CVEs listed in the output
  4. Attach the machine to a Pro subscription
  5. Run apt upgrade
  6. Run the CLI command again and verify that no CVEs are listed now

PS: I still need to write the unit and integration tests for this feature

github-actions[bot] commented 2 weeks ago

PR Checklist

How to use this checklist ### How to use this checklist #### PR Author For each section, check a box when it is true. Uncheck a box if it becomes un-true. Then check the box at the bottom of the PR description to re-run the action that creates this checklist. The action that creates and updates this comment will retain your edits. The action will fail if the checklist is not completed. #### PR Reviewer Check that the PR checklist action did not fail. Double check that the author filled out the checklist accurately. If you disagree with a checklist item, start a conversation. For example, the author may say they don't think integration tests are necessary, but you may disagree.
### Bug References None. #### Confirm - [ ] I've properly referenced all bugs that this PR fixes
How to properly reference fixed bugs * If this PR is related to a Jira item, include an `SC-1234` reference in the PR title * If this PR is fixes a GitHub issue, include a `Fixes: #1234` reference in the commit that fixes the issue * If this PR is fixes a Launchpad bug, include a `LP: #12345678` reference in the commit that fixes the issue
### Test Updates #### Unit Tests - [ ] I have updated or added any unit tests accordingly - [ ] No unit test changes are necessary for this change #### Integration Tests - [ ] I have updated or added any integration tests accordingly - [ ] No integration test changes are necessary for this change ### Documentation - [ ] Changes here need to be documented and I have referenced the docs PR in the description - [ ] No documentation updates are necessary for this change ### Does this PR require review from someone outside the core ubuntu-pro-client team? - [ ] Yes, and I have requested those reviews via GitHub - [ ] No