search

canonical / ubuntu-pro-client

Ubuntu Pro Client for offerings from Canonical
https://canonical-ubuntu-pro-client.readthedocs-hosted.com/en/latest/
GNU General Public License v3.0
52 stars 73 forks source link

Add links and alignment functionality to the CLI formatter tooling #3327

Closed renanrodrigo closed 2 days ago

renanrodrigo commented 4 days ago

Why is this needed?

This PR solves all of our problems because it implements some needed niceties on top of the CLI tools we are working on.

This is based on #3323 and should be merged after that. (It is the same context though, I didn't push the commits there because that one is kinda approved I guess)

Test Steps

Unit tests cover functionality, integration will come because the new CLI commands depend on this.

github-actions[bot] commented 4 days ago

PR Checklist

How to use this checklist ### How to use this checklist #### PR Author For each section, check a box when it is true. Uncheck a box if it becomes un-true. Then check the box at the bottom of the PR description to re-run the action that creates this checklist. The action that creates and updates this comment will retain your edits. The action will fail if the checklist is not completed. #### PR Reviewer Check that the PR checklist action did not fail. Double check that the author filled out the checklist accurately. If you disagree with a checklist item, start a conversation. For example, the author may say they don't think integration tests are necessary, but you may disagree.
### Bug References None. #### Confirm - [x] I've properly referenced all bugs that this PR fixes
How to properly reference fixed bugs * If this PR is related to a Jira item, include an `SC-1234` reference in the PR title * If this PR is fixes a GitHub issue, include a `Fixes: #1234` reference in the commit that fixes the issue * If this PR is fixes a Launchpad bug, include a `LP: #12345678` reference in the commit that fixes the issue
### Test Updates #### Unit Tests - [x] I have updated or added any unit tests accordingly - [ ] No unit test changes are necessary for this change #### Integration Tests - [ ] I have updated or added any integration tests accordingly - [x] No integration test changes are necessary for this change ### Documentation - [ ] Changes here need to be documented and I have referenced the docs PR in the description - [x] No documentation updates are necessary for this change ### Does this PR require review from someone outside the core ubuntu-pro-client team? - [ ] Yes, and I have requested those reviews via GitHub - [x] No
renanrodrigo commented 3 days ago

Bad, bad Fix CI