canonical / ubuntu.com

The official website for the Ubuntu operating system
https://ubuntu.com
Other
189 stars 190 forks source link

Switch from ip to tz for takeovers. #13899

Closed carkod closed 2 months ago

carkod commented 2 months ago

Done

QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-7175

Screenshots

[If relevant, please include a screenshot.]

Help

QA steps - Commit guidelines

webteam-app commented 2 months ago

Demo

Jenkins

demos.haus

petesfrench commented 2 months ago

Instead of removing the alternative method of finding a user's IP, could we keep it as a fallback?

carkod commented 2 months ago

Instead of removing the alternative method of finding a user's IP, could we keep it as a fallback?

Why do we need a fallback? What's your concern?

samhotep commented 2 months ago

@carkod do we know where else it was being used? IIRC we kept it because takeovers needed it, but if that was all we can remove it

samhotep commented 2 months ago

@carkod also the page here https://discourse.ubuntu.com/t/takeover-french-business-guide-to-multicloud/34968 doesn't seem to exist

samhotep commented 2 months ago

@carlos as we discussed it might be better to convert the timezone to lowercase https://github.com/canonical/ubuntu.com/blob/5d4771a8d9d58f9ed0069e88807e870ea785aac4/templates/base_index.html#L1142C28-L1142C42

Since takeovers use lowercase for target_country