canonical / ubuntu.com

The official website for the Ubuntu operating system
https://ubuntu.com
Other
197 stars 197 forks source link

Implement CVE detailed search #13923

Closed britneywwc closed 3 months ago

britneywwc commented 4 months ago

Done

QA

Issue / Card

Fixes WD-11717

Screenshots

[If relevant, please include a screenshot.]

Help

QA steps - Commit guidelines

webteam-app commented 4 months ago

Demo

Jenkins

demos.haus

carkod commented 3 months ago

I think it could be good to add an e2e tests once all is done.

juanruitina commented 3 months ago

Some early feedback:

Smaller, visual details we can iron out when we pair.

juanruitina commented 3 months ago

Clicking on "Show all results" causes the page to reload, can you check so I can give the full review?

britneywwc commented 3 months ago

@juanruitina Just fixed it, you can try again now :)

juanruitina commented 3 months ago

Only one minor thing to tweak: the last result doesn't have an HR above it. Other than that, this looks good to me, so +1ing this already.

About the still open filter-related issues: I understand they are out of scope for this specific PR, but let's make sure we fix them. Here it also includes repeated columns for repeated releases (for instance here: https://ubuntu-com-13923.demos.haus/security/cves?q=&detailed=true&version=jammy&status=&version=noble&status=&version=mantic&status=&version=jammy&status=&version=focal&status=)

Screenshot 2024-06-24 at 14 09 21