canonical / ubuntu.com

The official website for the Ubuntu operating system
https://ubuntu.com
Other
185 stars 190 forks source link

GROWENG-3818 changing legacy google analytics event to datalayer push #13954

Closed laszlokajtar closed 2 weeks ago

laszlokajtar commented 3 weeks ago

Done

QA

webteam-app commented 3 weeks ago

laszlokajtar is not a collaborator of the repo

carkod commented 2 weeks ago

Can you fix .js code formatting? Looking at this you probably just need:

prettier -w 'static/js/src/dynamic-forms.js' prettier -w 'static/js/src/kernel-form.js'

and we'll get this merged.

laszlokajtar commented 2 weeks ago

@carkod i don't think i have the proper setup to run the repo locally, so prettier actually gives me an error. i'm not sure how it'd reformat what i have, is this something i could do manually?

carkod commented 2 weeks ago

@carkod i don't think i have the proper setup to run the repo locally, so prettier actually gives me an error. i'm not sure how it'd reformat what i have, is this something i could do manually?

Unfortunately prettier doesn't output what needs to be fixed, there's a huge discussion about this, I'll push directly.

carkod commented 2 weeks ago

@laszlokajtar should be fixed now, can you check that everything looks good? Thanks.

laszlokajtar commented 2 weeks ago

@carkod thank you!