canonical / ubuntu.com

The official website for the Ubuntu operating system
https://ubuntu.com
Other
185 stars 190 forks source link

WD-10435 - intel iot page rebrand #13970

Closed lizzochek closed 5 days ago

lizzochek commented 2 weeks ago

Done

Rebrand intel-iot page.

QA

Issue / Card

WD-10435

webteam-app commented 2 weeks ago

Demo

Jenkins

demos.haus

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.12%. Comparing base (0277528) to head (0a75e8f). Report is 58 commits behind head on main.

:exclamation: Current head 0a75e8f differs from pull request most recent head a2daf01

Please upload reports for the commit a2daf01 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #13970 +/- ## ======================================= Coverage 74.12% 74.12% ======================================= Files 107 107 Lines 2864 2864 Branches 957 957 ======================================= Hits 2123 2123 Misses 715 715 Partials 26 26 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/canonical/ubuntu.com/pull/13970/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical)
juanruitina commented 2 weeks ago

There were a handful of repetitive small tweaks needed, so I went ahead and applied them myself. Hope that's OK.

There's some weird behaviour of the equal heights component on medium screens (see below), what can we do about it? Just stacking the three boxes would do the trick for me. / @lyubomir-popov

Screenshot 2024-06-21 at 12 20 39

lyubomir-popov commented 1 week ago

this h2 needs to be wrapped in a p-section--shallow: image

lyubomir-popov commented 1 week ago

There's some weird behaviour of the equal heights component on medium screens (see below), what can we do about it? Just stacking the three boxes would do the trick for me. / @lyubomir-popov

I think they are just stacking, that's why it looks a little under designed. Or did you have something else in mind?

lyubomir-popov commented 1 week ago

@juanruitina oh the markup is incorrect, this is what it should be like: image

lizzochek commented 1 week ago

@juanruitina @lyubomir-popov updated according to your comments

lyubomir-popov commented 1 week ago

these two should be in a single code snippet, at the moment theres two pres, causing too much space between lines image

this looks wrong - 2 "ands", 3 times the amount of text that should be in a title - @Sophie-32 is it possible to shorten or breakoff part of the heading and put it in a paragraph following the heading?: image

the last section before the footer on every page should have p-section--deep on it, to doulbe the amount of white space at the bottom: image