Open evilnick opened 1 week ago
Just FYI the 'woke' fails are because we can't police URLs to other sites
@evilnick where can I see the expected content for the pages and a full list of required changes? Please also provide links to pages no the demo that need to be checked
These are all the pages that are changed by this PR:
https://ubuntu-com-13997.demos.haus/kubernetes/docs/1.29/release-notes https://ubuntu-com-13997.demos.haus/kubernetes/docs/1.29/upgrading https://ubuntu-com-13997.demos.haus/kubernetes/docs/how-to-cos-lite https://ubuntu-com-13997.demos.haus/kubernetes/docs/ldap https://ubuntu-com-13997.demos.haus/kubernetes/docs/monitoring https://ubuntu-com-13997.demos.haus/kubernetes/docs/release-notes https://ubuntu-com-13997.demos.haus/kubernetes/docs/ceph https://ubuntu-com-13997.demos.haus/kubernetes/docs/storage https://ubuntu-com-13997.demos.haus/kubernetes/docs/upgrade-notes
There is no copy doc or anything for these pages, the sources are maintained in a different repository. You can see the history of the changes in this PR
Thanks for looking
Content looks good to me according to the PR you mentioned. Please fix listing errors and inclusive name check for me to review code
@lizzochek I literally can't fix the inclusive language check.
e.g.
[keystone-auth]: https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/keystone-auth/using-client-keystone-auth.md
it's a URL :shrug:
- `nrpe-external-master` (provides: `nrpe-external-master` on KCP and KW)
it's the name of a deprecated interface which we replaced, but people still need to know what the old one was called so they can update it.
I can't add <!-- woke ignore -->
lines before these things because the Markdown parser used on u.c then interprets everything until the next blank line as HTML which obviously messes everything up.
I will look at the jinja_lint test too, which I guess is new since we last updated K8s docs, but from a glance at the output it is complaining mostly about blank lines. The blank lines are usually only there to make the Markdown render properly, and, e.g. "The format for the --storage
option is <storage pool>,<size>,<number>
" is obviously not a collection of orphaned HTML tags. Any advice there appreciated!
Done
QA
./run serve
ordotrun
N.B. The content of these changes has already been reviewed