canonical / ubuntu.com

The official website for the Ubuntu operating system
https://ubuntu.com
Other
201 stars 199 forks source link

Implement macros for quote and image section #14149

Closed britneywwc closed 2 months ago

britneywwc commented 2 months ago

Done

QA

Issue / Card

Fixes WD-13122 and WD-13123

Screenshots

[If relevant, please include a screenshot.]

Help

QA steps - Commit guidelines

webteam-app commented 2 months ago

Demo

Jenkins

demos.haus

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.63%. Comparing base (be039bd) to head (94cc8cf). Report is 123 commits behind head on case-study-templates.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## case-study-templates #14149 +/- ## ===================================================== Coverage 69.63% 69.63% ===================================================== Files 109 109 Lines 3076 3129 +53 Branches 1056 1092 +36 ===================================================== + Hits 2142 2179 +37 - Misses 908 925 +17 + Partials 26 25 -1 ``` [see 19 files with indirect coverage changes](https://app.codecov.io/gh/canonical/ubuntu.com/pull/14149/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical)
petesfrench commented 2 months ago

This is awesome. Should definitely dial the Vanilla folk in on this if you haven't already. If we align our practices early on it could save some time down the line.

Bit of a nit pick, but the quote in the design is just using regular quotes: image

britneywwc commented 2 months ago

Thanks @petesfrench, I've addressed all of your comments and suggestion :) Could you have another look please? Re Vanilla, I am planning on getting their input once all the macro PRs are merged.