Closed britneywwc closed 2 months ago
Hey @jmuzina @pastelcyborg! I will be addressing comments of the macros usage in this PR. Is there a suggested way to import macros? The Vanilla build does not include macro files thus I'm not able to import them through npm, I'm currently just copy-pasting the macro codes directly.
Hey @jmuzina @pastelcyborg! I will be addressing comments of the macros usage in this PR. Is there a suggested way to import macros? The Vanilla build does not include macro files thus I'm not able to import them through npm, I'm currently just copy-pasting the macro codes directly.
Our intended approach at this point will just be copying the macros from the node_modules
directory into the templates/macros
directory of the project that's importing Vanilla, assuming said project is using Flask Base. For the sake of futureproofing, I'd just make sure your macros are in templates/macros
. When we have more a more fleshed-out importing process, I'll drop you a line and let you know exactly what that looks like.
Thanks for all the suggestions! I have addressed all the comments in this PR and the feature branch, I've also consolidated them in the list of "To-do" under the PR description.
As for the quotes, I will wait for the Vanilla PR to be merged since the quotes that are being used in the case studies are the same.
Heads up @britneywwc : https://github.com/canonical/vanilla-framework/pull/5275 has macro markup that is ready for use, but there are a couple issues related to HR spacing that are blocking it - they will be solved by https://github.com/canonical/vanilla-framework/pull/5241.
Hi @britneywwc, if you have any thoughts about any of your experience using or creating macros as part of this work, it would be helpful to document them so we can work to improve them.
If that’s the case, could you record your thoughts in a Google Doc or something similar so we can address any issues? Thanks!!
Sure thing @jmuzina, I'll try to consolidate it in a google doc and send it over.
hr
that doesn't span the full width should have the class is-muted
:Before:
After:
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 69.63%. Comparing base (
5c64f62
) to head (887b958
). Report is 15 commits behind head on case-study-templates.
Can we move these 3 cols ot the left, so the body content aligns with the body copy of the article underneath?
also, are the h2s always going to be always this short?
@britneywwc Another thought here - if you want to be able to use the Hero macro without copy-and-pasting it into your project, you can make a fairly minor modification to the server config, as seen in this PR:
https://github.com/canonical/ubuntu.com/pull/14209
I'll leave it up to you if you'd like to - might save you a bit of effort/maintenance.
@lyubomir-popov For the highlights example, yes the h2 will only be "Highlights"
Pushed a couple of quote adjustments from code & design review this morning with @pastelcyborg and @lyubomir-popov.
Done
To-do
QA
Issue / Card
Fixes WD-14119
Screenshots
[If relevant, please include a screenshot.]
Help
QA steps - Commit guidelines