Closed jamiedawsonyoung closed 8 years ago
@richmccartney Can you provide a screenshot of what @jamiedawsonyoung refers to?
I strongly disagree with changing to default browser dropdown as this involves rebuilding the browser functionality in divs and js. The browsers have full assessibilty support which we would have to support if we rebuild it.
That said we can modify the style of the input (not the dropdown) in WebKit. This can be seen here as the sort by and series filters; https://jujucharms.com/store
On Fri, 19 Feb 2016, 12:49 Inayaili de León Persson < notifications@github.com> wrote:
@richmccartney https://github.com/richmccartney Can you provide a screenshot of what @jamiedawsonyoung https://github.com/jamiedawsonyoung refers to?
— Reply to this email directly or view it on GitHub https://github.com/ubuntudesign/vanilla-framework/issues/171#issuecomment-186202010 .
Is that not the default WebKit style?
We have increased the padding, changed the background to white instead of the gradient and added a dark grey border.
On Fri, 19 Feb 2016, 13:03 Inayaili de León Persson < notifications@github.com> wrote:
Is that not the default WebKit style?
— Reply to this email directly or view it on GitHub https://github.com/ubuntudesign/vanilla-framework/issues/171#issuecomment-186205354 .
The only thing that changes on Chrome is the font size that I can see…
I'm guessing @Lucapaulina et al. might come up with suggestions for styles of select elements… I'd like to explore this further.
Some examples to think about:
Sorry here is the styled dropdowns: https://demo.jujucharms.com/services/?store
Could that not be the default for vanilla? It follows the styles of the other inputs.
I can't see why it couldn't be used.
On Fri, Feb 19, 2016 at 2:13 PM Inayaili de León Persson < notifications@github.com> wrote:
Could that not be the default for vanilla? It follows the styles of the other inputs.
— Reply to this email directly or view it on GitHub https://github.com/ubuntudesign/vanilla-framework/issues/171#issuecomment-186230411 .
Sure we could add it. I'll gather the styles and add them to this issue to be worked on.
On Fri, 19 Feb 2016, 21:36 Luca Paulina notifications@github.com wrote:
I can't see why it couldn't be used.
On Fri, Feb 19, 2016 at 2:13 PM Inayaili de León Persson < notifications@github.com> wrote:
Could that not be the default for vanilla? It follows the styles of the other inputs.
— Reply to this email directly or view it on GitHub < https://github.com/ubuntudesign/vanilla-framework/issues/171#issuecomment-186230411
.
— Reply to this email directly or view it on GitHub https://github.com/ubuntudesign/vanilla-framework/issues/171#issuecomment-186417745 .
Here are the current MAAS GUI styles for select dropdown as per Jamie's original comments. Might help when deciding how these are to look.
@anthonydillon @jamiedawsonyoung @richmccartney We decided we'd keep default radio and checkboxes for Vanilla. Shouldn't select inputs follow the same rationale in that case?
Oh did we, I thought we were using the positive colour for them. It is a design decision really.
On Mon, 9 May 2016 at 15:12 Inayaili de León Persson < notifications@github.com> wrote:
@anthonydillon https://github.com/anthonydillon @jamiedawsonyoung https://github.com/jamiedawsonyoung @richmccartney https://github.com/richmccartney We decided we'd keep default radio and checkboxes for Vanilla. Shouldn't select inputs follow the same rationale in that case?
— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/ubuntudesign/vanilla-framework/issues/171#issuecomment-217875707
Positive colour only for Juju (green) and MAAS (orange).
Isn't it a little odd to have a different colour for selection controls for each product? I'm not sure they should be 'branded' I think we could come up with a consistent style for all? (green like Client?) ;-)
Yes, that's what we talked about at the workshop, if I understood correctly. The idea is that we'd leave them as they are for now, but the products should align at some point (soon).
Added wontfix label. Correct me if I understood wrong, but I think the current agreement is that Vanilla will have unstyled checkboxes, radio buttons and select inputs (dropdowns).
Can we make the padding etc the same as on Maas (@richmccartney) and use the chevron?
Understand that when you click the drop-down the styling will be dictated by the browser / OS