canonical / vanilla-framework

From community websites to web applications, this CSS framework will help you achieve a consistent look and feel.
https://vanillaframework.io
GNU Lesser General Public License v3.0
841 stars 167 forks source link

Remove or update p-link--strong? #1845

Closed spencerbygraves closed 6 years ago

spencerbygraves commented 6 years ago

p-link--strong looks the same as our new h5 style, which could lead to confusion when used together on a page.

image

We could remove it and use either:

In the example below, the strong links could be blue (one of the original reasons for the strong style was to avoid lists of blue links, but we may now feel that it's not a problem).

image

Or we keep it for use on dark backgrounds only and update the description in docs:

The .p-link--strong class should be used on hyperlinks that require emphasis or on a dark background.

anthonydillon commented 6 years ago

If I remember rightly, the reason we created the strong link were the tables that were deemed a "sea of blue". Do we still have this issue? Is it something to take into account?

spencerbygraves commented 6 years ago

@anthonydillon yep, that would be something to consider.

For reference, MAAS is now using blue links in tables

kwm14 commented 6 years ago

Agreed in working group

kwm14 commented 6 years ago

Issue created here to deprecate- https://github.com/vanilla-framework/vanilla-framework/issues/1996