search

canonical / vanilla-framework

From community websites to web applications, this CSS framework will help you achieve a consistent look and feel.
https://vanillaframework.io
GNU Lesser General Public License v3.0
841 stars 167 forks source link

What does row .no-border do? #244

Closed yaili closed 8 years ago

yaili commented 8 years ago

Does it remove all borders? Or just some?

richmccartney commented 8 years ago

@yaili It removes all borders. I have an idea for all box model layers where we can do something like .no-border to remove all borders or .no-border--top. Second class would remove just the top border and we could replicate this pattern for padding and margins.

See https://github.com/ubuntudesign/maas-gui-vanilla-theme/blob/master/scss/generic/_helpers.scss for example as I plan to bring this into Vanilla core.

barrymcgee commented 8 years ago

@yaili Has this question been addressed? If so, can you please close this ticket :)

yaili commented 8 years ago

@barrymcgee This one in specific has, but I think we need another one to address these names as they don't seem very intuitive.

barrymcgee commented 8 years ago

@yaili Hopefully adoption of BEM across the framework should address this.