search

canonical / vanilla-framework

From community websites to web applications, this CSS framework will help you achieve a consistent look and feel.
https://vanillaframework.io
GNU Lesser General Public License v3.0
838 stars 167 forks source link

Pagination links turn blue when visited #2458

Closed bartaz closed 5 years ago

bartaz commented 5 years ago

Describe the bug

Not sure if that is intended behaviour (but looks quite weird and confusing), but pagination links in pagination buttons (dark text colour by default) turn blue when link is visited (because they inherit styles from visited link).

To Reproduce Steps to reproduce the behavior:

  1. Go to pagination docs: https://docs.vanillaframework.io/patterns/pagination/
  2. Click on links in example paginations
  3. See how visited buttons become blue

Expected behavior Pagination buttons should not change colour when visited

Screenshots

Screenshot 2019-08-07 at 14 40 25
kwm14 commented 5 years ago

@bartaz that is the intended behavior, $color-link is our default link color and are 10% darker when already visited.

But you raise a valid point if the links are using .p-link--soft it should inherit 10% darker of that color, rather than referring to our default $color-link

kwm14 commented 5 years ago

Looking back tat the link saga I don't really want to open up changing link color styles.

Going forward we will keep as is, but if any more frequent issues are raised about the visited link we can revisit this issue 👍