Form help text too close when $multi = 1

canonical / vanilla-framework

From community websites to web applications, this CSS framework will help you achieve a consistent look and feel.

https://vanillaframework.io

GNU Lesser General Public License v3.0

841 stars 167 forks source link

Form help text too close when $multi = 1 #2488

Closed Caleb-Ellis closed 5 years ago

Caleb-Ellis commented 5 years ago

Describe the bug If $multi = 1 (i.e. density is high) the help text underneath text and select inputs is too close. On checkboxes the spacing is fine, however.

Screenshots screenshot_1

screenshot_2

anthonydillon commented 5 years ago

I fixed this in MAAS with:

.p-form-help-text {
  padding-top: $spv-inner--small;
  line-height: 1.5;
}

lyubomir-popov commented 5 years ago

I noticed that, I think I fixed it in (have to double check, if not I'll merge the fix there) https://github.com/canonical-web-and-design/vanilla-framework/pull/2452

So a fix will be available as soon as it merges.

lyubomir-popov commented 5 years ago

That pr removes the margin-top -.5rem on many text elements, which among other things solves Robin's issue of headings being too close to classless divs / imgs, and this issue. Still needs some finalising before I can merge it, so for now if you can put an XXX against the local fix and reference this issue, I'll then go and clean up once we release the fix.