search

canonical / vanilla-framework

From community websites to web applications, this CSS framework will help you achieve a consistent look and feel.
https://vanillaframework.io
GNU Lesser General Public License v3.0
825 stars 166 forks source link

List pattern placeholders cannot be included without all list patterns #2808

Closed lyubomir-popov closed 4 years ago

lyubomir-popov commented 4 years ago

Describe the bug The placeholders here are inside the @mixin vf-p-lists: https://github.com/canonical-web-and-design/vanilla-framework/blob/64fe763f601f2f3702b84749d84804a15024e629/scss/_patterns_lists.scss#L267

In order to extend say %vf-list from maas for example, you need to include the entire mixin, which includes all list patterns

Expected behavior The placeholders should be in a separate mixin that doesn't output anything, so they can be included cleanly.

anthonydillon commented 4 years ago

This issue is still valid. This will cause an issue when importing a particular list. For example, import "vf-p-list-divided".