search

canonical / vanilla-framework

From community websites to web applications, this CSS framework will help you achieve a consistent look and feel.
https://vanillaframework.io
GNU Lesser General Public License v3.0
835 stars 165 forks source link

Move example-specific styling out of framework SCSS #3199

Open bartaz opened 4 years ago

bartaz commented 4 years ago

Currently we have some example-specific styling (for grids, layouts) in framework SCSS (.grid-demo .app-demo) and sometimes inline in example HTML (making it visible in CodePen).

We should find a better solution for where to keep them, so they are separate from the Vanilla framework codebase, are not visible in HTML code in CodePens, but are still useful and possibly have access to SCSS variables.

One possible solution would be to create a example.scss stylesheet, built to separate example.css (outside of Vanilla build.css).

Related: discussion on application layout review: https://github.com/canonical-web-and-design/vanilla-framework/pull/3175#discussion_r466469614

bartaz commented 2 weeks ago

Triaging: effort low/medium? Low impact.

Dropping this from v4, but it's something to consider as part of new architecture (how to separate core design system styling from custom example styling).

syncronize-issues-to-jira[bot] commented 2 weeks ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-15136.

This message was autogenerated