search

canonical / vanilla-framework

From community websites to web applications, this CSS framework will help you achieve a consistent look and feel.
https://vanillaframework.io
GNU Lesser General Public License v3.0
825 stars 166 forks source link

No default for labels #3201

Closed anthonydillon closed 3 years ago

anthonydillon commented 4 years ago

There should be a default label pattern (I recommend a grey one). If you use p-label there is no styling.

matthewpaulthomas commented 4 years ago

Vanilla is currently consistent with most other toolkits here: labels use the same typeface, size, weight, and color as non-label text.

In #2848 I suggested using grey to mean “this is a label for something that isn’t editable right now” — whether it’s the label for a disabled control (also common in other toolkits), or the label for data that is never editable.

Sorry, I misunderstood this issue — I thought it was referring to <label> rather than <div class="p-label-…">.

lyubomir-popov commented 4 years ago
anthonydillon commented 3 years ago

Has there been any movement on this issue?

lyubomir-popov commented 3 years ago

No, Not to my knowledge.

@gomboli should this move through the new UX WG pipeline? @anthonydillon where would this be used? We have existing rules around making labels gray in MAAS for example (for uneditable fields), so we'd need to know what exactly this is intended for. Can you point me to a few cases where you might want to use it but have resorted to local solutions?

anthonydillon commented 3 years ago

This came up when looking at the new UA wireframes. Mostly this is to cover the missing default usage of this pattern which is unique to labels at the moment.

lyubomir-popov commented 3 years ago

Sounds like a small task, adding to this iteration and I'll ping you tomorrow with some quesitons.

lyubomir-popov commented 3 years ago

We had a meeting with @anthonydillon @ziheliu214 @bartaz, and agreed to: