search

canonical / vanilla-framework

From community websites to web applications, this CSS framework will help you achieve a consistent look and feel.
https://vanillaframework.io
GNU Lesser General Public License v3.0
797 stars 163 forks source link

p-divider: Allow removal of specific dividers #4877

Open petesfrench opened 9 months ago

petesfrench commented 9 months ago

Pattern to amend

p-divider

Visual

Before: image After: image

Code

.p-divider {
  .p-divider__block.no-divider {
    &::before {
      content: none;
    }
  }
}

Context

Design required a section of p-dividers without the initial divider, see figma. Could also be used to remove any other dividers

jmuzina commented 1 month ago

@petesfrench Hi, from what I can tell this was implemented as default behavior in this commit (this PR) in v4.11.0 and onward.

Can you check here and verify it's working as you need? Thanks!

petesfrench commented 1 month ago

Thanks @jmuzina! I have (sort of) applied the change - unfortunately, I found another visual bug, so have had to change how we apply the p-divider class. Could you take a look for me please? https://github.com/canonical/ubuntu.com/pull/13884

bartaz commented 1 month ago

@petesfrench This component seems to be deprecated and not used in rebranded pages anymore, so from Vanilla point of view we don't want to put too much focus on this anymore.

Is this part of any new design? As far as I understand we should not be using those anymore.