search

canonical / vanilla-framework

From community websites to web applications, this CSS framework will help you achieve a consistent look and feel.
https://vanillaframework.io
GNU Lesser General Public License v3.0
833 stars 164 forks source link

Application layout doesn't accommodate tag logos #5014

Closed steverydz closed 1 week ago

steverydz commented 7 months ago

Component/pattern to amend

The application layout

Visual

Screenshot 2024-02-29 at 15 45 55 Screenshot 2024-02-29 at 15 47 53

Context

The application layout doesn't allow for latest logos which include a tag and are intended to have no space between them and the top of the screen.

There is also a related issue where in the examples the circle/icon is separate from the word mark which is for the unpinned navigation on narrow viewports. This doesn't work with this type of logo as the text isn't the same height of the logo tag/icon.

bartaz commented 7 months ago

Yes, that's long overdue. We had an attempt on addressing this (https://github.com/canonical/vanilla-framework/pull/4691), but it got blocked on an ongoing redesign/spec of the whole side navigation.

But I guess it's good to bring this back to attention and decide on WG how to proceed with this.

So far I think some apps (Anbox, LXD, etc) have some local solutions around this problem, so maybe this can be shared somehow.

danielmutis commented 6 months ago

WG: This issue is validated. We have some solutions in the new side nav spec, which hasn't been fully approved yet. This includes more changes than just the logo. For now, there will be some short-term solutions to this problem until we get a finalised side nav.

bartaz commented 1 week ago

Duplicate of #4711

syncronize-issues-to-jira[bot] commented 1 week ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-15231.

This message was autogenerated