search

canonical / vanilla-framework

From community websites to web applications, this CSS framework will help you achieve a consistent look and feel.
https://vanillaframework.io
GNU Lesser General Public License v3.0
833 stars 164 forks source link

The keyword 'searchfield-cancel-button' used on the 'appearance' property was deprecated and has now been removed. It will no longer have any effect. #5088

Closed dimaqq closed 2 months ago

dimaqq commented 4 months ago

Describe the bug

Chrome complains about the deprecated feature:

The keyword 'searchfield-cancel-button' used on the 'appearance' property was deprecated and has now been removed. It will no longer have any effect.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://juju.is/docs/juju/lxd#heading--create-a-controller
  2. Look at console

Additional context

Looking through the code, I'm not entirely sure about the ultimate source, but git blame for matching scss suggests that it's a very old bit of code.

bartaz commented 4 months ago

Thanks. Yes, this seems to be used in search box component:

image

https://github.com/canonical/vanilla-framework/blob/4109529d291740aa752b4e24967ef0d056d157ae/scss/_base_forms.scss#L167-L170

We need to verify if it can be safely removed (and what effect that would have on webkit based browsers). Or find an supported alternative value.

syncronize-issues-to-jira[bot] commented 2 months ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-13782.

This message was autogenerated

pastelcyborg commented 2 months ago

From what I can tell, this pseudo-element has already effectively been deprecated and removed from Webkit. I had to apply some specific styles to even get it to show up, because it currently has no appearance or metrics:

image

Even with my styles, it can't be tabbed to with the keyboard. I don't think removing this will have any ill effects at all, since with the CSS currently in place, this pseudo-element isn't visible. Additionally, Vanilla already provides a reset button that looks and works as intended.