search

canonical / vanilla-framework

From community websites to web applications, this CSS framework will help you achieve a consistent look and feel.
https://vanillaframework.io
GNU Lesser General Public License v3.0
837 stars 165 forks source link

Change icon alignment to `middle` when next to paragraph text #5103

Open jmuzina opened 4 months ago

jmuzina commented 4 months ago

Component/pattern to amend

Icon Set icons to vertical-align: middle when they are next to paragraph text.

Visual

image

Context

See comment from @lyubomir-popov : https://github.com/canonical/vanilla-framework/pull/5093#issuecomment-2137035576 comment from @jmuzina : https://github.com/canonical/vanilla-framework/pull/5093#issuecomment-2137510915

There is already some code for changing appearance of icons when next to various heading levels. Probably we can add some styling for icons inside <p> elements here: https://github.com/canonical/vanilla-framework/blob/b1d651365b0714586e6ea14349dea763819c256e/scss/_patterns_icons.scss#L88

syncronize-issues-to-jira[bot] commented 2 months ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-13630.

This message was autogenerated

bartaz commented 3 weeks ago

Triaged: fix in v4. We have already a PR in progress for this.