canonical / vanilla-framework

From community websites to web applications, this CSS framework will help you achieve a consistent look and feel.
https://vanillaframework.io
GNU Lesser General Public License v3.0
798 stars 163 forks source link

Fix favicon not rendering properly in google search. #5183

Closed jmuzina closed 6 days ago

jmuzina commented 1 week ago

Done

Updates site to use 48x48 version of the Vanilla logo as a favicon, instead of the old 32x32 version. We are also now serving a favicon locally for search engines, following the practice done by c.com & u.com.

See Google favicon rendering documentation for more information.

Fixes WD-12464, MM thread

QA

Google Recrawl

After this is merged, it may take a few days for the icon to change on Google search results. If it still hasn't been fixed after some time, we should submit a recrawl request which should fix the issue.

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

webteam-app commented 1 week ago

Demo

Jenkins

demos.haus

jmuzina commented 1 week ago

@lyubomir-popov Please provide an export of the new Vanilla logo to use for the favicon, per MM discussion

jmuzina commented 1 week ago

@bartaz @pastelcyborg @lyubomir-popov Updated with new logo, please review :)

lyubomir-popov commented 6 days ago

LGTM