canonical / vanilla-framework

From community websites to web applications, this CSS framework will help you achieve a consistent look and feel.
https://vanillaframework.io
GNU Lesser General Public License v3.0
830 stars 165 forks source link

Update Media Object to support new color theme variables #5187

Closed pastelcyborg closed 3 months ago

pastelcyborg commented 3 months ago

Done

Please note the code comment at the top of the file: we can no longer use the vf-url-friendly-color function for theming the icons, as it cannot interpolate CSS variables during compilation (since they only exist at runtime). Instead, I hard-coded different inline icons with specific colors for light/dark themes (paper will use the light theme colors). I think this works, particularly given this element is intended to be deprecated anyway.

Fixes WD-11867

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

webteam-app commented 3 months ago

Demo

Jenkins

demos.haus