canonical / vanilla-framework

From community websites to web applications, this CSS framework will help you achieve a consistent look and feel.
https://vanillaframework.io
GNU Lesser General Public License v3.0
798 stars 163 forks source link

Fix Percy tests being queued against PRs with Percy label when the ne… #5191

Closed jmuzina closed 6 days ago

jmuzina commented 1 week ago

Fixes Percy tests being triggered against PRs that have the Percy label on label events when the label that was just applied is not the Percy needed label.

The logic has been refined as such:

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

webteam-app commented 1 week ago

Demo

Jenkins

demos.haus

jmuzina commented 6 days ago

@bartaz @pastelcyborg Be careful applying labels to PRs that already have the Percy label on them until this is merged - they'll run Percy tests multiple times. I've been manually cancelling runs against workflows that were already tested; we should merge this asap, then rebase effected PRs

I've removed the Percy label from those PRs in the meantime.