search

canonical / vanilla-framework

From community websites to web applications, this CSS framework will help you achieve a consistent look and feel.
https://vanillaframework.io
GNU Lesser General Public License v3.0
841 stars 167 forks source link

Merge/Rebase Percy Artifacts #5282

Closed jmuzina closed 2 months ago

jmuzina commented 3 months ago

We should update the Percy prepare workflow so that the latest changes from main are included in the testing artifacts.

The current Percy workflow checks out the pull request source here. We should update this to check out a merge commit or to rebase against main.

If any merge/rebase conflicts are found, the workflow should immediately fail, prompting contributor/maintainer to rebase/merge themselves.

This will reduce cases where perceived visual regressions are seen in tests, only because the PR was not merged or rebased against main.

syncronize-issues-to-jira[bot] commented 3 months ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-13965.

This message was autogenerated