canonical / vanilla-framework

From community websites to web applications, this CSS framework will help you achieve a consistent look and feel.
https://vanillaframework.io
GNU Lesser General Public License v3.0
823 stars 166 forks source link

Expand existing card component to include rebranded variant #5319

Open mtruj013 opened 3 weeks ago

mtruj013 commented 3 weeks ago

Component/pattern to amend

https://vanillaframework.io/docs/patterns/card

Visual

image

Context

We're using these increasingly across recent rebranding builds, but there's really no best practice in place for implementation. We're currently using a mixture of existing vanilla classes and some custom styles to match the design, but given that the existing card variants are barely used anymore it seems appropriate that this new variant be officially upstreamed

syncronize-issues-to-jira[bot] commented 3 weeks ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-14368.

This message was autogenerated

bartaz commented 1 week ago

WG notes:

Dani: we need to unify the component. Every time we have a new card it seems we are getting new design. Lyubo: this design it based on marketing needs, on top of paper background (used on sites only for now) Max: it's unclear what are the common "properties" of a card component (is it just a container with a border/background)?

Lyubo: maybe confusion is to call it a card, it's a highlight mechanism

Max: in apps we also use cards, but it's inconsistent beetwen apps (because we don't have rules about what comes in the cards, what are use cases) Nina: +1, we need rules for cards

Lyubo: Maybe next step would be to: 1) audit card usage in apps 2) see if any of the current styles ca nbe merged 3) make card container styling consistent 4) (if there is enough overlap) spec out the api, what can go in and what can't

Dani: the design process for the card will require time Nina - will start audit in apps, Lyubo may do it with sites

WG: Validated

For the time being implementation should be custom in projects that need it, until we have spec of the component for DS.