canonical / vanilla-framework

From community websites to web applications, this CSS framework will help you achieve a consistent look and feel.
https://vanillaframework.io
GNU Lesser General Public License v3.0
838 stars 167 forks source link

Overhaul print CSS styles and better integrate with Vanilla core #5350

Open pastelcyborg opened 1 month ago

pastelcyborg commented 1 month ago

Component/pattern to amend

Presently, the print CSS styles for various sites tend to live in their own file:

https://github.com/canonical/ubuntu.com/blob/main/static/sass/print.scss

These print.css files also often live separately from core site styles, resulting in an extra network request to retrieve them.

There's probably an opportunity here to create some print styles as part of Vanilla core, so these don't need to be created uniquely for each site. We'll need to do some analysis to determine what various sites are doing with their print styles and which parts of these print styles could be upstreamed into new Vanilla core print styles.

syncronize-issues-to-jira[bot] commented 1 month ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-14926.

This message was autogenerated

danielmutis commented 1 month ago

WG: how relevant is this today? How often do people print from websites? This could be considered as part of the new architecture work. This part of Vanilla is very old and hasn't been touched in a long time. Lyubo: should this be taken into consideration for each component? @pastelcyborg @bartaz and the tribe to discuss what to do about this inside the tribe.

bartaz commented 1 month ago

I was pretty sure we have some basic print styles, but I can't find any (apart from utility allowing you to hide things from print (https://vanillaframework.io/docs/utilities/no-print).

I guess there is not much value in addressing it in current codebase as we are moving towards new architecture. Print styles (from web) could be considered as part of new design system specs and architecture.