canonical / vanilla-framework

From community websites to web applications, this CSS framework will help you achieve a consistent look and feel.
https://vanillaframework.io
GNU Lesser General Public License v3.0
845 stars 167 forks source link

Add CSS range syntax to breakpoints settings page #5395

Closed mcslayer closed 1 month ago

mcslayer commented 1 month ago

Done

Updated breakpoints settings page to use new CSS range syntax, based on conversation in #5287

Fixes #5394

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

Screenshot

Screenshot 2024-10-22 at 10 12 33

webteam-app commented 1 month ago

mcslayer is not a collaborator of the repo

bartaz commented 1 month ago

Demo: https://vanilla-framework-5395.demos.haus/docs/settings/breakpoint-settings

bartaz commented 1 month ago

Thanks @mcslayer. Just a small suggestion for future PRs: when you are mentioning issues that PR fixes add Fixes before the issue id. Only this way GH will automatically close the issue when PR is merged. I fixed that here in the description.

mcslayer commented 1 month ago

Oh, that's right. I applied this approach in the initial pull requests, but later concluded that it doesn't look very elegant. I apologize for the oversight and will be more careful moving forward.