canonical / vanilla-framework

From community websites to web applications, this CSS framework will help you achieve a consistent look and feel.
https://vanillaframework.io
GNU Lesser General Public License v3.0
849 stars 169 forks source link

CTA Block: Excessive bottom padding #5397

Open jmuzina opened 1 month ago

jmuzina commented 1 month ago

While building https://github.com/canonical/canonical.com/pull/1406, I noticed a visual quirk with the CTA block: we have given it padding-bottom: $spv--x-large here:

https://github.com/canonical/vanilla-framework/blob/78211ca79d33f316815a660be4ff91089fef40d3/scss/_patterns_cta.scss#L19

This causes some extra spacing beneath the CTA block that is not present in CTA blocks that don't use our .p-cta-block.

Default:

Screenshot 2024-10-23 at 3 19 22 PM

Expected (no bottom padding):

Screenshot 2024-10-23 at 3 19 37 PM
syncronize-issues-to-jira[bot] commented 1 month ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-16100.

This message was autogenerated