canonical / vault-operator

A machine charm for Vault
https://charmhub.io/vault?channel=1.16/stable
Apache License 2.0
0 stars 2 forks source link

fix: Access kv secret using secret ID #254

Closed saltiyazan closed 3 months ago

saltiyazan commented 3 months ago

Description

fixes https://github.com/canonical/vault-operator/issues/243

Not to lose the secret://modeluuid/standard_secret_id format of the secret ID which is required to access the secret in cross model relations we get the secret with the secret ID that was initially returned by add_secret and initially stored in the relation databag.

Bug reported in Juju https://bugs.launchpad.net/juju/+bug/2075153

Checklist:

DanielArndt commented 3 months ago

I'm going to be a jerk and disable auto-merge here, because I think my comment on the other PR is worth considering. It could always come as a follow-up, but I figured it would be worthwhile for you to consider before merging, and I know I was a little late on the review.