search

canonical / wlcs

Wayland Conformance Test Suite
GNU General Public License v2.0
50 stars 14 forks source link

(#332) LayerSurfaceLayoutTest includes a test for a -1 exclusion zone #333

Closed mattkae closed 8 months ago

mattkae commented 8 months ago

fixes #332

Implemented a test for zwlr_layer_surface_v1_set_exclusive_zone(-1), which means that the surface should ignore all exclusion zones (e.g. a background)

mattkae commented 8 months ago

I'm a bit confused at what this test is doing, and I think it's because the test isn't testing what you think it is.

I am attempting to test that ignoring exclusive zones while you are a fullscreened surface gives you the whole output, regardless of there being attached surfaces with exclusive zones defined.

I think it would be more obvious what it's doing if either:

* You set up the exclusive surfaces first, then set up the `exclusive=-1` surface and checked its position, or

* You set up the `exclusive=-1` surface, checked its position, _then_ set up the exclusive surfaces and asserted that no reconfiguration occured.

(It's possible that this is more usefully two tests)

These two tests sound like a better idea tho