canonical / workshops

Workshops
GNU General Public License v3.0
51 stars 11 forks source link

Add delay for tooltips #306

Closed alielbashir closed 1 year ago

alielbashir commented 1 year ago

This adds a delay to the tooltips in the config editor fixes #289

I have some questions regarding this since it's not mentioned in the issue itself:

github-actions[bot] commented 1 year ago

Everyone contributing to this PR have now signed the CLA. Thanks!

jpnurmi commented 1 year ago

Thanks, this is a great improvement! I think we could make the delay even slightly longer. For comparison, GTK defaults to 500ms.

  • In case Tooltip widgets would be used in the future in other pages, should this be moved up the widget tree?
  • IconButton widgets have tooltips but they don't have a waitDuration parameter. Would this difference in delays be detrimental enough to UX to warrant not making this change?

I'd probably specify the wait duration in the global theme data because I doubt we want those immediately appearing tooltips anywhere in the app. That way, it should apply to icon buttons, too. :)

alielbashir commented 1 year ago

You're right, with this change tooltips in icon buttons also inherit the TooltipThemeData, and with it the specified delay. I also set the delay to 500ms like you recommended

jpnurmi commented 1 year ago

@Feichtmeier, any thoughts on specifying a default wait duration for tooltips in yaru.dart?

Feichtmeier commented 1 year ago

Sure can do