search

canonical / xdg_desktop_portal.dart

Mozilla Public License 2.0
12 stars 5 forks source link

refactoring: (split classes to different files) #44

Closed aospiridonov closed 2 years ago

aospiridonov commented 2 years ago

Classes are split into different files

github-actions[bot] commented 2 years ago
Hey! aospiridonov has not signed the Canonical CLA which is required to get this contribution merged on this project. Please head over to https://ubuntu.com/legal/contributors to read more about it.
robert-ancell commented 2 years ago

Thanks for this, I've also got a branch in which I've been working on this. If you want to continue with this PR, can you make a PR that just has one portal split out? That way it's easier to review and then land the other portal changes.

aospiridonov commented 2 years ago

I specifically separated the current state portals to different files in this PR to make it easier to maintain the code further.

aospiridonov commented 2 years ago

Thanks for this, I've also got a branch in which I've been working on this. If you want to continue with this PR, can you make a PR that just has one portal split out? That way it's easier to review and then land the other portal changes.

I suggest syncing and adding new portals in parallel. If everything is in one dart file, there will be difficulties with the merge.

robert-ancell commented 2 years ago

See https://github.com/canonical/xdg_desktop_portal.dart/pull/50 for the first step in refactoring the internal classes so things can be split out.